Min checkliste for “best practice” og reviewing c/c++ kode.
Det meste piv stjålet fra John T. Baldwin – http://www.literateprogramming.com/Baldwin-inspect.pdf eller “C++ Coding Standards” af Herb Sutter
Brugen af vector eller string hjælper med, at lave mere sikker og fleksibel kode.
int intarray[13];
should be
int intarray[TOT_MONTHS+1];
char entry[TOTAL_ENTRIES]; should be char entry[LAST_ENTRY+1];
The first example is extremely error-prone and often gives rise to off-by-one errors in the code. The preferred (second) method permits the writer to use the LAST_ENTRY identifier to refer to the last item in the array. Instances which require a buffer of a certain size are rarely rendered invalid by this practice, which results in the buffer being one element bigger than absolutely necessary.
auto months_in_year = 12;
should be
const auto months_in_year = 12;
#define MAX_FILES 20
should be
const auto MAX_FILES = 20;
Delt data giver bindinger mellem kode, hvilket hurtigt giver problemer med debuging, og vedligeholdelse. Specielt et problem hvor flere tråde har access til delt data.